[fix bug 948057] (B2G Browser) Zooming in on modal window causes graphical issues #1729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only case I could find here that this wouldn't fix is if there's a modal created with I'm wondering if |
Good suggestion, I'll see to adding it. |
|
PR updated! |
|
Looks good! r+ 🔍 |
jpetto
added a commit
that referenced
this pull request
Feb 24, 2014
…dal-window-causes-graphical-issues [fix bug 948057] (B2G Browser) Zooming in on modal window causes graphical issues
alexgibson
deleted the
bug-948057-btg-zooming-on-modal-window-causes-graphical-issues
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox OS performs a layout/reflow on
position:fixedelements when the user pinch/zooms. This affectsMozilla.Modal, resulting in layout issues and odd glitches.This PR switches to using
position: absolutefor small viewports, which does not exhibit the same behavior and performs more predictably.I've tested this change on a GeeksPhone Peak device.